Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Conversation

@cpanato
Copy link
Contributor

@cpanato cpanato commented Nov 15, 2020

What this PR does / why we need it:
Add e2e tests for cluster-api-provider-packet.
This PR setup the e2e and make it ready when we setup a PROW Job to run it

Followup: Add the conformance tests, it is running in another branch, using this one as base.

final logs of the test execution

Ran 2 of 2 Specs in 3199.965 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

Ginkgo ran 1 suite in 53m26.0287044s
Test Suite Passed
removing ssh key
2020/11/15 17:24:28 [DEBUG] DELETE https://api.equinix.com/metal/v1/ssh-keys/551cdb6c-8ec1-4733-a674-00435e73e211
SSH Key 551cdb6c-8ec1-4733-a674-00435e73e211 successfully deleted.
================ REDACTING LOGS ================
All sensitive variables are redacted

/assign @detiber @gianarb

special thanks to @rawkode for giving some credits to test/run the servers

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 15, 2020
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 15, 2020
Copy link
Contributor

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0b30d06 into kubernetes-retired:master Nov 16, 2020
@cpanato cpanato deleted the tests-e2e branch November 16, 2020 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants