- 
                Notifications
    You must be signed in to change notification settings 
- Fork 42
🏃 e2e fixes #201
🏃 e2e fixes #201
Conversation
| dist | ||
|  | ||
| # Tilt | ||
| .tiltbuild/ | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: new line
| .PHONY: modules | ||
| modules: ## Runs go mod to ensure modules are up to date. | ||
| go mod tidy | ||
| cd $(TOOLS_DIR); go mod tidy | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: new line
| "main.go", "go.mod", "go.sum", "api", "controllers", "pkg" | ||
| ] | ||
| } | ||
| } No newline at end of file | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: new line
| Rebased on top of latest HEAD | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, detiber The full list of commands accepted by this bot can be found here. The pull request process is described here 
Needs approval from an approver in each of these files:
 
 Approvers can indicate their approval by writing  | 
What this PR does / why we need it:
Fixes up issues with the e2e test configuration
Builds on top of #197