Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

🐛 control plane template should use correct variable #198

Merged
merged 1 commit into from
Nov 2, 2020
Merged

🐛 control plane template should use correct variable #198

merged 1 commit into from
Nov 2, 2020

Conversation

@rawkode
Copy link
Contributor

@rawkode rawkode commented Oct 28, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 28, 2020
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2020
@rawkode
Copy link
Contributor Author

rawkode commented Oct 29, 2020

cc @gianarb @deitch

cpanato
cpanato approved these changes Nov 1, 2020
View reviewed changes
Copy link
Contributor

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2020
@detiber
Copy link
Contributor

detiber commented Nov 2, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, detiber, rawkode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3a8386b into kubernetes-retired:master Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jacobsmith928 jacobsmith928 Awaiting requested review from jacobsmith928

@mrmrcoleman mrmrcoleman Awaiting requested review from mrmrcoleman

1 more reviewer

@cpanato cpanato cpanato approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cpanato cpanato

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rawkode @detiber @k8s-ci-robot @cpanato