Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

🏃 Rev version for v0.3.4 release #192

Merged
merged 1 commit into from
Oct 19, 2020
Merged

🏃 Rev version for v0.3.4 release #192

merged 1 commit into from
Oct 19, 2020

Conversation

@detiber
Copy link
Contributor

@detiber detiber commented Oct 19, 2020

What this PR does / why we need it:

Updates the version in preparation for the v0.3.4 release

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Oct 19, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 19, 2020
cpanato
cpanato approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e763ed7 into kubernetes-retired:master Oct 19, 2020
@cpanato
Copy link
Contributor

cpanato commented Oct 19, 2020

/hold for a mantainer to review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2020
@cpanato
Copy link
Contributor

cpanato commented Oct 19, 2020

whoopsie!! this was too fast

@cpanato
Copy link
Contributor

cpanato commented Oct 19, 2020

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2020
@detiber
Copy link
Contributor Author

detiber commented Oct 19, 2020

@cpanato it's all good :)

@detiber detiber deleted the release-v0.3.4 branch October 19, 2020 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@deitch deitch Awaiting requested review from deitch

@mrmrcoleman mrmrcoleman Awaiting requested review from mrmrcoleman

1 more reviewer

@cpanato cpanato cpanato approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cpanato cpanato

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@detiber @k8s-ci-robot @cpanato