Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Conversation

@gianarb
Copy link
Contributor

@gianarb gianarb commented Aug 5, 2020

This PR enables the Elastip IP management for Control Plane in CCM.

One of the Packet CCM responsibility is to health check the Control
Plane IP and move the Elastic IP to an healthy control plane.

In order to do that the configuration has to be set to CCM secret.

This PR enables the Elastip IP management for Control Plane in CCM.

One of the Packet CCM responsibility is to health check the Control
Plane IP and move the Elastic IP to an healthy control plane.

In order to do that the configuration has to be set to CCM secret.
@gianarb gianarb requested a review from deitch August 5, 2020 08:17
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Aug 5, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2020
@deitch
Copy link
Contributor

deitch commented Aug 7, 2020

/lgtm

@deitch
Copy link
Contributor

deitch commented Aug 7, 2020

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deitch, gianarb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2b5e0cd into kubernetes-retired:master Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants