Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Conversation

@gianarb
Copy link
Contributor

@gianarb gianarb commented Jul 28, 2020

/assign @deitch

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jul 28, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2020
@deitch
Copy link
Contributor

deitch commented Jul 28, 2020

I think when this is done, we need to update clusterctl to know about the new release? Or does it pick it up as latest?

@deitch
Copy link
Contributor

deitch commented Jul 28, 2020

/lgtm

@deitch
Copy link
Contributor

deitch commented Jul 28, 2020

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deitch, gianarb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit adbf8a6 into kubernetes-retired:master Jul 28, 2020
@gianarb
Copy link
Contributor Author

gianarb commented Jul 28, 2020

I think when this is done, we need to update clusterctl to know about the new release? Or does it pick it up as latest?

it picks up the latest 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants