Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

Conversation

@gianarb
Copy link
Contributor

@gianarb gianarb commented Jul 3, 2020

No effort is small enough to justify inactivity.

We are following the example we get from ClusterAPI and the Kubernetes
community: kubernetes-sigs/cluster-api#3285

/cc @vincepri

/kind cleanup

No effort is small enough to justify inactivity.

We are following the example we get from ClusterAPI and the Kubernetes
community: kubernetes-sigs/cluster-api#3285
@k8s-ci-robot k8s-ci-robot requested a review from vincepri July 3, 2020 10:03
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gianarb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 3, 2020
@gianarb gianarb requested a review from deitch July 3, 2020 10:03
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 3, 2020
@deitch
Copy link
Contributor

deitch commented Jul 3, 2020

Sure, why not?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8a32813 into kubernetes-retired:master Jul 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants