Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

fix import paths #16

Merged
merged 1 commit into from
Jun 24, 2019
Merged

fix import paths #16

merged 1 commit into from
Jun 24, 2019

Conversation

amy
Copy link
Contributor

@amy amy commented Jun 24, 2019 •
edited
Loading

fixes #15

@k8s-ci-robot
Copy link
Contributor

Welcome @amy!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-docker 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-docker has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2019
@chuckha
Copy link
Contributor

chuckha commented Jun 24, 2019

Yep, this is the name i would expect, thank you for the cleanup!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amy, chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2019
chuckha
chuckha suggested changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like something went wonky in goimports

actuators/actuators.go Show resolved Hide resolved
actuators/machine.go Show resolved Hide resolved
cmd/capd-manager/main.go Outdated Show resolved Hide resolved
chuckha
chuckha approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! i'll wait a little bit for someone else to /lgtm (or timeout after some amount of time and add /lgtm myself)

@ashish-amarnath
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2e852e2 into kubernetes-retired:master Jun 24, 2019
@amy amy mentioned this pull request Jul 3, 2019
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chuckha chuckha chuckha approved these changes

@detiber detiber Awaiting requested review from detiber

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@ashish-amarnath ashish-amarnath

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency Issues
4 participants
@amy @k8s-ci-robot @chuckha @ashish-amarnath