Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use go modules to replace $GOPATH based dependencies #135

Closed
wants to merge 1 commit into from

Conversation

xing-yang
Copy link
Collaborator

@xing-yang xing-yang commented Jul 3, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR uses go modules to replace $GOPATH based dependencies.

Which issue(s) this PR fixes:
Fixes #60
Investigate whether using go modules can fix the dependency issue.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Uses go modules to replace $GOPATH based dependencies.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2019
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 3, 2019
@k8s-ci-robot
Copy link
Contributor

@xing-yang: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-csi-external-snapshotter-unit 3b28542 link /test pull-kubernetes-csi-external-snapshotter-unit
pull-kubernetes-csi-external-snapshotter-alpha 3b28542 link /test pull-kubernetes-csi-external-snapshotter-alpha
pull-kubernetes-csi-external-snapshotter 3b28542 link /test pull-kubernetes-csi-external-snapshotter

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 3, 2019
@xing-yang xing-yang closed this Jul 3, 2019
dobsonj pushed a commit to dobsonj/external-snapshotter that referenced this pull request Mar 8, 2024
…ncy-openshift-4.16-ose-csi-snapshot-controller

OCPBUGS-25548: Updating ose-csi-snapshot-controller-container image to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Break out snapshot CRD libraries into separate repo
2 participants