Address various linter (staticcheck, modernize, etc.) comments. #1319
+117
−536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, fix bug to properly identify dynamically created group snapshots for fixed group snapshot content names when group snapshots are being deleted.
What type of PR is this?
/kind bug
What this PR does / why we need it: This PR seeks to update the external-snapshotter repo so various Go linters
no longer raise any warnings for the code. The repo should follow modern Go constructs and best practices.
Secondly, this PR fixes an edge case bug where volumegroupsnapshot deletion fails handling dynamically created
volumegroupsnapshots.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: I am happy to discuss any part of my change.
Does this PR introduce a user-facing change?: yes