add check continue VGS deletion #1164
Conversation
this commit adds check to continue deleting the volumegroupsnapshot in case there are no snapshotcontent found under that group. Signed-off-by: yati1998 <ypadia@redhat.com>
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yati1998 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @yati1998. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/XS
yati1998
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
yati1998
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
@Madhu-1 @xing-yang please take a look. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
@yati1998 Is there an issue opened for this bug fix? If there is one, please add to your PR description. |
| @@ -251,6 +251,10 @@ func (ctrl *csiSnapshotSideCarController) deleteCSIGroupSnapshotOperation(groupS | |||
| for _, contentRef := range groupSnapshotContent.Status.PVVolumeSnapshotContentList { | |||
| snapshotContent, err := ctrl.contentLister.Get(contentRef.VolumeSnapshotContentRef.Name) | |||
| if err != nil { | |||
| if errors.IsNotFound(err) { | |||
| klog.Infof("snapshot content %v not found", contentRef.VolumeSnapshotContentRef.Name) | |||
There was a problem hiding this comment.
This should be a warning. If snapshot content not found, that means it is somehow forcefully deleted. A snapshot content can't be deleted if group snapshot handle is still in its status.
Can you tell me how you reproduced this problem?
There was a problem hiding this comment.
yes even I thought the same, but this issue was reproducible when we repeatedly create and delete a VGS. As per my debug and testing, since the creation and deletion was taking place with same name within seconds, it seems there was a sync issue due to which the snapshot content got deleted . There is a script that we used to reproduce this issue, let me know if you want I can share it with you.
There was a problem hiding this comment.
Hey, I think we dont need this check anymore, it seems the VGS is getting successfully deleted.
this commit adds check to continue deleting the
volumegroupsnapshot in case there are no snapshotcontent found under that group.
#1035