Document Volume Group Snapshot feature in the README file #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/M
Madhu-1
reviewed
Jul 18, 2024
leonardoce
force-pushed
the
update-readme
branch
from
0ce14dc
to
498c8aa
Compare
|
Thank you @Madhu-1! |
|
@leonardoce Thank you 🎉 /lgtm |
k8s-ci-robot
added
the
lgtm
|
Looks like trivy scan failed. |
|
Yes, we need to update some dependencies. |
leonardoce
force-pushed
the
update-readme
branch
from
498c8aa
to
d48c0d2
Compare
k8s-ci-robot
removed
the
lgtm
|
Thank you, @jmccormick2001, for having a look at this. |
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
leonardoce
force-pushed
the
update-readme
branch
from
d48c0d2
to
8b182cc
Compare
|
I rebased it over the latest master. |
|
/lgtm @xing-yang PTAL |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leonardoce, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Mention volume group snapshots in the README file
Which issue(s) this PR fixes:
Fixes #1117
Special notes for your reviewer:
This PR changes
client/config/crd/kustomization.yamlto install the VolumeGroupSnapshots CRDs at the same time as the VolumeSnapshot CRDs. To we want to do that? Otherwise, we can continue requiring a separate installation.In that case, I'll change the README to document that step too.
Does this PR introduce a user-facing change?: