Improve error format in VolumeSnapshotError

[hairyhum]

Is your feature request related to a problem?/Why is this needed

In kanister controller https://github.com/kanisterio/kanister when creating volume snapshots we monitor its status to detect whether it's ready or failed.
When extracting the error from VolumeSnapshotError.Message it's just a string, usually composed with multiple layers of error strings.
We'd like to be able to distinguish between different types of errors (e.g. recoverable and non-recoverable), but currently all we can do is to match the error text.

Describe the solution you'd like in detail

The type of VolumeSnapshotError can be extended to include something like error type or code.
For example:

type VolumeSnapshotError struct {
	Time *metav1.Time `json:"time,omitempty" protobuf:"bytes,1,opt,name=time"`
	// Add code from the limited set
	ErrorCode *int64 `json:"errorCode,omitempty" protobuf:"bytes,3,opt,name=errorCode"`
	// OR:
	// Add type from limited set
	ErrorType *string `json:"errorType,omitempty" protobuf:"bytes,3,opt,name=errorType"`
	// Message can still be there
	Message *string `json:"message,omitempty" protobuf:"bytes,2,opt,name=message"`
}

Alternatively formatting of error message in VolumeSnapshotError.Message can be changed to include error type while keeping it a string.

Describe alternatives you've considered

Currently alternative is to match on error string, which is harder to maintain because text could be changed.

Additional context

[hairyhum]

Another option is to record reason from updateSnapshotErrorStatusWithEvent function there.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.