-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit on CSI gRPC conn loss #55
Exit on CSI gRPC conn loss #55
Conversation
Signed-off-by: Grant Griffiths <grant@portworx.com>
Welcome @ggriffiths! |
Hi @ggriffiths. Thanks for your PR. I'm waiting for a kubernetes-csi or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign gnufied |
/ok-to-test |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggriffiths, gnufied The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Grant Griffiths grant@portworx.com
What type of PR is this?
What this PR does / why we need it:
This will exit the sidecar container when its gRPC connection to the CSI driver is lost. When a CSI driver goes down, we do not want the sidecar container on that node to still be leader.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: