update client go to the latest version #490

kvalliyurnatt · 2025-03-26T17:20:51Z

What type of PR is this?

/kind bug

What this PR does / why we need it:
This PR updates the client-go version to v0.32.3, currently this is set to v1.5.2 which is a really old version of client-go. Not sure if this was introduced due to some specific need.

Which issue(s) this PR fixes:
Fixes #489

Does this PR introduce a user-facing change?:
NONE

linux-foundation-easycla · 2025-03-26T17:20:54Z

The committers listed above are authorized under a signed CLA.

✅ login: kvalliyurnatt (fa2a5b6, f74cfd9, a6d2f3f)

k8s-ci-robot · 2025-03-26T17:20:59Z

Welcome @kvalliyurnatt!

It looks like this is your first PR to kubernetes-csi/external-resizer 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/external-resizer has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-03-26T17:21:00Z

Hi @kvalliyurnatt. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mowangdk · 2025-03-31T11:51:26Z

/ok-to-test

sunnylovestiramisu · 2025-03-31T21:46:08Z

Interesting why dependabot does not update it?

/lgtm

msau42 · 2025-04-01T16:21:13Z

go.mod

 	k8s.io/apimachinery v0.32.2
 	k8s.io/apiserver v0.32.0
-	k8s.io/client-go v1.5.2
+	k8s.io/client-go v0.32.3


The client-go version is overridden by L84, so this change theoretically shouldn't do anything

@msau42 is there a reason to keep L84 around or could we remove that ?

The client-go version is overridden by L84, so this change theoretically shouldn't do anything

I think it's better to remove replace in go.mod if not necessary? Actually, I found this issue on CSI AIO testing. And this could affect users relying on this repository.

I removed the replace on L84

I think we should just remove all the replace statements. We only need them if we import k8s.io/kubernetes (which is not supported). But we have never imported that from git history of go.mod.

huww98 · 2025-04-04T17:48:28Z

go.mod

 	github.com/google/gofuzz v1.2.0 // indirect
 	github.com/kubernetes-csi/csi-lib-utils v0.21.0
 	golang.org/x/oauth2 v0.25.0 // indirect
 	golang.org/x/term v0.28.0 // indirect


I think it is strange that these 3 indirect requires are not in the block below. Maybe we can take the chance to fix this too.

It's doesn't match the issue, We can fix it individually

sunnylovestiramisu · 2025-04-04T21:08:45Z

go.mod


-replace k8s.io/client-go => k8s.io/client-go v0.32.0
-
 replace k8s.io/component-base => k8s.io/component-base v0.32.0


I think all these replace can be removed?

Then why don't we just remove these?

@kvalliyurnatt could you remove all these replace?

msau42 · 2025-04-07T17:05:53Z

/release-note-none
/lgtm
/approve

k8s-ci-robot · 2025-04-07T17:05:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kvalliyurnatt, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

update client go to the latest version

f74cfd9

k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 26, 2025

k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 26, 2025

k8s-ci-robot requested review from chrishenzie and sunnylovestiramisu March 26, 2025 17:20

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 26, 2025

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 26, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2025

k8s-ci-robot assigned sunnylovestiramisu Mar 31, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2025

msau42 reviewed Apr 1, 2025

View reviewed changes

remove the replace command from go mod

fa2a5b6

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2025

kvalliyurnatt requested review from mowangdk and msau42 April 3, 2025 18:12

huww98 reviewed Apr 4, 2025

View reviewed changes

sunnylovestiramisu reviewed Apr 4, 2025

View reviewed changes

remove all replace commands from go mod

a6d2f3f

k8s-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 7, 2025

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 7, 2025

kvalliyurnatt requested review from huww98 and sunnylovestiramisu April 7, 2025 16:57

k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 7, 2025

k8s-ci-robot assigned msau42 Apr 7, 2025

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 7, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2025

k8s-ci-robot merged commit 6d07f88 into kubernetes-csi:master Apr 7, 2025
6 checks passed


		replace k8s.io/client-go => k8s.io/client-go v0.32.0

		replace k8s.io/component-base => k8s.io/component-base v0.32.0

update client go to the latest version #490

update client go to the latest version #490

Conversation

kvalliyurnatt commented Mar 26, 2025

Uh oh!

linux-foundation-easycla bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 26, 2025

Uh oh!

k8s-ci-robot commented Mar 26, 2025

Uh oh!

mowangdk commented Mar 31, 2025

Uh oh!

sunnylovestiramisu commented Mar 31, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

msau42 commented Apr 7, 2025

Uh oh!

k8s-ci-robot commented Apr 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

linux-foundation-easycla bot commented Mar 26, 2025 •

edited

Loading