Skip to content

Conversation

@AndrewSirenko
Copy link
Contributor

@AndrewSirenko AndrewSirenko commented Feb 25, 2025

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind feature

What this PR does / why we need it:

Users requested that all kubernetes-csi sidecars serve leader, work queue, process, and Go runtime metrics via Kubernetes legacymetrics. These metrics are only served by external-provisioner today due to kubernetes-csi/external-provisioner#579.

We recently updated csi-lib-utils to serve additional registries via PR kubernetes-csi/csi-lib-utils#189.

This PR ensures this sidecar serves those additional metrics.

Testing:

  • See that new metrics were added via this gist: https://gist.github.com/AndrewSirenko/2d3bcd1cbc47541cab4f4fae9561fec0
  • Built all sidecar, deployed alongside EBS CSI Driver v1.40. Saw new metrics when scraping each sidecar /metrics endpoint.
  • Also tested upgrade case: No errors when upgrading EBS CSI Driver via helm from revision with default sidecars to these custom sidecars.
  • Excercised dynamic provisioning, snapshot, resize, and modify workflows. No errors. Workqueue metrics increased.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Serve additional leader election, work queue, process, and Go runtime metrics

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 25, 2025
@jsafrane
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit 1368835 into kubernetes-csi:master Feb 26, 2025
6 checks passed
@AndrewSirenko
Copy link
Contributor Author

/cherry-pick release-1.13

@k8s-infra-cherrypick-robot

@AndrewSirenko: new pull request created: #478

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants