Update dependency go modules for k8s v1.28.0 #332
Conversation
984feece Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e6059 fixed broken links of testgrid dashboard de2fba88 Merge pull request kubernetes-csi#233 from andyzhangx/andyzhangx-patch-1 cee895e1 remove windows 20H2 build since it's EOL long time ago 670bb0ef Merge pull request kubernetes-csi#229 from marosset/fix-codespell-errors 35d5e783 Merge pull request kubernetes-csi#219 from yashsingh74/update-registry 63473cc9 Merge pull request kubernetes-csi#231 from coulof/bump-go-version-1.20.5 29a5c76c Merge pull request kubernetes-csi#228 from mowangdk/chore/adopt_kubernetes_recommand_labels 8dd28211 Update cloudbuild image with go 1.20.5 1df23dba Merge pull request kubernetes-csi#230 from msau42/prow 1f92b7e7 Add ginkgo timeout to e2e tests to help catch any stuck tests 2b8b80ea fixing some codespell errors c10b6780 Merge pull request kubernetes-csi#227 from coulof/check-sidecar-supported-versions 72984ec0 chore: adopt kubernetes recommand label b0555351 Header bd0a10b6 typo c39d73c3 Add comments f6491af0 Script to verify EOL sidecar version 901bcb5a Update registry k8s.gcr.io -> registry.k8s.io git-subtree-dir: release-tools git-subtree-split: 984feece4bafac3aad74deeed76a500a0c485fb1
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/XXL
Sneha-at
force-pushed
the
module-update-master
branch
from
5037791 to
0f878b1
Compare
| sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect | ||
| sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect | ||
| sigs.k8s.io/yaml v1.3.0 // indirect | ||
| ) |
There was a problem hiding this comment.
@msau42 Should I delete these replace statements here?
There was a problem hiding this comment.
If the script is adding it then let's keep it. We should investigate how to modify the script to remove it if it's unnecessary.
Sneha-at
force-pushed
the
module-update-master
branch
2 times, most recently
from
43dfcfe to
02eb353
Compare
go.mod
Outdated
| github.com/google/gofuzz v1.2.0 // indirect | ||
| github.com/imdario/mergo v0.3.12 // indirect | ||
| github.com/kubernetes-csi/csi-lib-utils v0.13.0 | ||
| github.com/kubernetes-csi/csi-lib-utils v0.15.0 |
There was a problem hiding this comment.
Keep this at 0.14.0 until we resolve the dependency issue.
There was a problem hiding this comment.
This is causing dependency issue only for certain libraries from the otel package. It did not throw any error for "external-resizer" in make test. SHould we still use v14 (may be to keep all sidecars on same dependency?) then we might want to as well revisit node-driver-registrar
There was a problem hiding this comment.
I think it's better to be consistent across all the sidecars.
There was a problem hiding this comment.
Updated csi-lib-utils to v0.14.0
| sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect | ||
| sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect | ||
| sigs.k8s.io/yaml v1.3.0 // indirect | ||
| ) |
There was a problem hiding this comment.
If the script is adding it then let's keep it. We should investigate how to modify the script to remove it if it's unnecessary.
Sneha-at
force-pushed
the
module-update-master
branch
from
02eb353 to
529df22
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, Sneha-at The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 participants
Ran kubernetes-csi/csi-release-tools go-get-kubernetes.sh -p 1.28.0