Update lib-external-provisioner and cleanup constraints #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
I was able to get past conflicts with lib-external-provisioner, but now I'm hitting conflicts with external-snapshotter. @jsafrane can you help cleanup the constraints in external-snapshotter? |
ddebroy
reviewed
Mar 8, 2019
Gopkg.toml
Outdated
|
|
||
| [[constraint]] | ||
| [[override]] | ||
| name = "github.com/kubernetes-sigs/sig-storage-lib-external-provisioner" |
There was a problem hiding this comment.
This name may also need to switch to sigs.k8s.io/sig-storage-lib-external-provisioner? I kept running dep ensure failures without the above switch - so just wanted to call it out.
k8s-ci-robot
added
size/XL
This comes from lib-external-provisioner using master client-go. Update to v1.14.0-beta.1 should help, however, you need to update external-snapshotter first. |
k8s-ci-robot
added
size/XXL
|
Update: Things compile now. I'm trying to run the hostpath e2es with my private image and many are failing. Am debugging... |
|
|
This may be because glog got pulled in again for some reason... |
|
actually no, glog was already in vendor before this change |
msau42
force-pushed
the
update-lib
branch
2 times, most recently
from
221e339 to
973e671
Compare
|
Trying again with just "dep ensure" instead of "dep ensure -update". |
msau42
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Tested and passed with PD driver. I'm still having issues with hostpath e2es but I think it's unrelated to this change. |
|
Michelle Au <notifications@github.com> writes:
39493 csi-hostpath-provisioner-0/csi-provisioner: /csi-provisioner flag redefined: log_dir
39494 csi-hostpath-provisioner-0/csi-provisioner: panic:
/csi-provisioner flag redefined: log_dir
I've seen such issues when `vendor` wasn't complete and something was
pulled in from my GOPATH.
|
jsafrane
reviewed
Mar 13, 2019
|
/lgtm |
k8s-ci-robot
added
the
lgtm
andyzhangx
added a commit
to andyzhangx/external-provisioner
that referenced
this pull request
Dec 16, 2023
b54c1ba49 Merge pull request kubernetes-csi#246 from xing-yang/go_1.21 5436c81e9 Change go version to 1.21.5 267b40e97 Merge pull request kubernetes-csi#244 from carlory/sig-storage b42e5a2de nominate self (carlory) as kubernetes-csi reviewer a17f536fc Merge pull request kubernetes-csi#210 from sunnylovestiramisu/sidecar 011033de2 Use set -x instead of die 5deaf667c Add wrapper script for sidecar release git-subtree-dir: release-tools git-subtree-split: b54c1ba49469d4d5d1b5d75285e8868ffe3d328f
kbsonlong
pushed a commit
to kbsonlong/external-provisioner
that referenced
this pull request
Dec 29, 2023
Fixes ReconcileVA for non-migratable drivers
tyuchn
added a commit
to tyuchn/external-provisioner
that referenced
this pull request
Mar 19, 2024
dc4d0ae20 Merge pull request kubernetes-csi#249 from jsafrane/use-go-version e681b170e Use .go-version to get Kubernetes go version b54c1ba49 Merge pull request kubernetes-csi#246 from xing-yang/go_1.21 5436c81e9 Change go version to 1.21.5 267b40e97 Merge pull request kubernetes-csi#244 from carlory/sig-storage b42e5a2de nominate self (carlory) as kubernetes-csi reviewer a17f536fc Merge pull request kubernetes-csi#210 from sunnylovestiramisu/sidecar 011033de2 Use set -x instead of die 5deaf667c Add wrapper script for sidecar release f8c8cc4c7 Merge pull request kubernetes-csi#237 from msau42/prow b36b5bfdc Merge pull request kubernetes-csi#240 from dannawang0221/upgrade-go-version adfddcc9a Merge pull request kubernetes-csi#243 from pohly/git-subtree-pull-fix c4650889d pull-test.sh: avoid "git subtree pull" error 7b175a1e2 Update csi-test version to v5.2.0 987c90ccd Update go version to 1.21 to match k/k 2c625d41d Add script to generate patch release notes f9d5b9c05 Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version b01fd5372 Bump csi-driver-host-path version up to v1.12.0 984feece4 Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools 1f7e60599 fixed broken links of testgrid dashboard git-subtree-dir: release-tools git-subtree-split: dc4d0ae20a3dcce17fbfc745fb1f1e3b10cd9644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for #238