add makefile to generate book using docker image of mdbook 0.2.1 #50
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/assign @saad-ali |
|
/assign @lpabon |
|
I don't like commits which contain completely unrelated changes. Can you split out the typo fix and write some better commit messages? Kubernetes is still in the process of more formally defining that (see kubernetes/community#2050) but https://chris.beams.io/posts/git-commit/ is mentioned. |
| # limitations under the License. | ||
|
|
||
| doc: | ||
| docker run --rm -v $(CURDIR):/data -u $(id -u):$(id -g) -it chengpan/mdbook:0.2.1 mdbook build ./book |
|
@pohly The reason I add |
Develop can use `make doc` command to generate doc without installing extra rust dependencies.
leakingtapan
force-pushed
the
docker-mdbook
branch
from
e4b7af1 to
5814ff8
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: leakingtapan If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@leakingtapan Thanks. This PR looks good to me. We've had spurious changes in the docs before caused by using slightly different versions of mdbook, so I think this is useful. |
|
@lpabon could you approve the PR since you are the owner |
| # limitations under the License. | ||
|
|
||
| doc: | ||
| docker run --rm -v $(CURDIR):/data -u $(id -u):$(id -g) -it chengpan/mdbook:0.2.1 mdbook build ./book |
There was a problem hiding this comment.
Can you work with @lpabon to get the container chengpan/mdbook:0.2.1 and its source checked in to an official location?
lpabon
left a comment
lpabon
left a comment
There was a problem hiding this comment.
chengpan there is no need for a docker image. mdbook is a single file and has no dependencies
|
I talked to @leakingtapan offline. We concluded with adding a link on the README.md page to his repo for those who do not want to install mdbook and want to use his docker container. |
5 participants
add makefile to generate book using docker image for mdbook 0.2.1. With this, people just need to run
make docto generate docs without installing extra rust dependencies