-
Notifications
You must be signed in to change notification settings - Fork 152
Add support for topology requirements in volume creation tests #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add support for topology requirements in volume creation tests #580
Conversation
Signed-off-by: GitHub <noreply@github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ShashwatHiregoudar The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @ShashwatHiregoudar. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
andyzhangx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
|
/retest |
|
@jsafrane please help review and /approve |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Added Configurable Topology Requirements to CSI Sanity Tests
I have added support for injecting TopologyRequirement into CreateVolumeRequest calls in the CSI sanity tests. This allows testing drivers that require specific topology constraints.
Special notes for your reviewer:
Usage
To use this feature, create a YAML file with your topology requirements. Example:
Then run csi-sanity with the flag:
csi-sanity --csi.endpoint=<endpoint> --csi.testtopologyrequirements=path/to/topology.yamlDoes this PR introduce a user-facing change?: