Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/feature
What this PR does / why we need it:
Source: @jsafrane's kubernetes-csi/external-provisioner#1262
gomock is not able to match newly generated Protobuf messages from csi-test, because their private fields differ. Implement a custom message matcher for projects that need to mock gRPCs can use.
See the passing tests in the following PRs for proof that this works as intended (which rely on a replace directive pointing to my fork of csi-test):
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Will rebase other PRs in sidecar repositories once we release a new patch version of csi-test.
We should cherry-pick this to
release-5.3
.Does this PR introduce a user-facing change?: