add ControllerPublishSupported

[ArbelNathan]

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

The lack of ControllerPublishSupported in Resources cause this line to always return false.

Which issue(s) this PR fixes:

Fixes #316

Special notes for your reviewer:
if you see a more elegant way to enter the ControllerPublishSupported into Resources please feel free to fix it.

Does this PR introduce a user-facing change?:

None

[k8s-ci-robot]

Welcome @ArbelNathan!

It looks like this is your first PR to kubernetes-csi/csi-test 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-test has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ArbelNathan. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pohly]

If r.ControllerPublishSupported was always false (= unset), why was ControllerPublishVolume called (as mentioned in #316)?

Are there perhaps ControllerPublishVolume calls which need to be guarded with an if check?

[ArbelNathan]

Every test that uses ControllerPublishVolume has its own guard..

If only ControllerPublishVolume can set the volumeInfo's NodeId so maybe that cl.ControllerPublishSupported check is redundant and we should just leave the info.NodeID != "" there (and remove ControllerPublishSupported in Resources I added), but I don't know If we wanna just removed guards.

[pohly]

I prefer to remove ControllerPublishSupported. The code becomes simpler without it and we don't need it because when info.NodeID != "", then we know that ControllerUnpublishVolume can and must be called.

[pohly]

Let's also remove NodeStageSupported. It's only checked once, which can replaced with a isNodeCapabilitySupported call.

[ArbelNathan]

ok, done.

[pohly]

This looks good, thanks for investigating. Can you squash into a single commit?

[ArbelNathan]

This looks good, thanks for investigating. Can you squash into a single commit?

squashed

[pohly]

/lgtm
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArbelNathan, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [pohly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment