Skip to content

Conversation

@chrishenzie
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR bundles the external-attacher in the mock CSI driver deployment manifest. Including this pod makes it easier for users to quickly test volume attachment / detachment behavior.

Does this PR introduce a user-facing change?:

NONE

/sig storage
/assign @msau42
/assign @Jiawei0227

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 28, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 28, 2021
@Jiawei0227
Copy link
Contributor

/lgtm thanks, Chris!

@msau42
Copy link
Collaborator

msau42 commented Jan 28, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrishenzie, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2021
@Jiawei0227
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit ebcc37e into kubernetes-csi:master Jan 29, 2021
@chrishenzie chrishenzie deleted the add-external-attacher branch January 29, 2021 00:04
@pohly
Copy link
Contributor

pohly commented Jan 29, 2021

Including this pod makes it easier for users to quickly test volume attachment / detachment behavior.

Do users really deploy the mock driver to test attach/detach? Who are those users and why do they use the mock driver for this?

@chrishenzie
Copy link
Contributor Author

chrishenzie commented Feb 1, 2021

I'm one of those users. I've been making changes to the CSIAttacher and AttachDetachController and am using this mock driver deployment combined with E2E tests to gather performance metrics when working in kind.

@msau42
Copy link
Collaborator

msau42 commented Feb 1, 2021

One of the main purposes of mock driver is for Kubernetes developers to test changes to Kubernetes/sidecars. So I think we should be supporting use of all Kubernetes features.

@pohly
Copy link
Contributor

pohly commented Feb 2, 2021

I don't mind adding it, I was just wondering. When I test sidecars, I do it with the hostpath driver, therefore I was wondering why someone would prefer to do it with the mock drivver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants