-
Notifications
You must be signed in to change notification settings - Fork 152
Add external-attacher to mock CSI driver deployment #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external-attacher to mock CSI driver deployment #318
Conversation
|
/lgtm thanks, Chris! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrishenzie, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Do users really deploy the mock driver to test attach/detach? Who are those users and why do they use the mock driver for this? |
|
I'm one of those users. I've been making changes to the CSIAttacher and AttachDetachController and am using this mock driver deployment combined with E2E tests to gather performance metrics when working in kind. |
|
One of the main purposes of mock driver is for Kubernetes developers to test changes to Kubernetes/sidecars. So I think we should be supporting use of all Kubernetes features. |
|
I don't mind adding it, I was just wondering. When I test sidecars, I do it with the hostpath driver, therefore I was wondering why someone would prefer to do it with the mock drivver. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR bundles the external-attacher in the mock CSI driver deployment manifest. Including this pod makes it easier for users to quickly test volume attachment / detachment behavior.
Does this PR introduce a user-facing change?:
/sig storage
/assign @msau42
/assign @Jiawei0227