Add tests for volume creation from source #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
darkowlzz
force-pushed
the
create-vol-from-source
branch
from
ad5d797 to
3d2d8af
Compare
pohly
approved these changes
Mar 20, 2019
Contributor
pohly
left a comment
pohly
left a comment
There was a problem hiding this comment.
/lgtm
/approve
I also tried this against the hostpath driver, which passed. However, several other tests failed. But that's a different topic and very well may be real issues in the driver.
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: darkowlzz, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Adds support for volume creation from source volume and snapshot in the mock driver and the corresponding sanity tests. Also, adds volume CLONE_VOLUME capability to the mock driver's supported capability list.
darkowlzz
force-pushed
the
create-vol-from-source
branch
from
3d2d8af to
de9122e
Compare
k8s-ci-robot
removed
the
lgtm
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
suneeth51
pushed a commit
to suneeth51/csi-test
that referenced
this pull request
Sep 11, 2019
…source Add tests for volume creation from source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for volume creation from source volume and snapshot in the
mock driver and the corresponding sanity tests.
Also, adds volume CLONE_VOLUME capability to the mock driver's supported
capability list.
Fixes #118