Fix snapshot test #116
Merged
Fix snapshot test #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove snapshot invalid token test, modify the workflow for creating a snapshot with the same name but different volume source id in order to use valid volume id.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Contributor
Author
xing-yang
reviewed
Sep 13, 2018
| Expect(ok).To(BeTrue()) | ||
| Expect(serverError.Code()).To(Equal(codes.Aborted)) | ||
| }) | ||
|
|
Contributor
There was a problem hiding this comment.
I think we still need some kind of invalid token test? I thought you want to remove the next test "should fail when the starting_token is greater than total number of snapshots".
Contributor
There was a problem hiding this comment.
Just talked to Jing. We don't know what kind of token a driver will use so we don't really know what is invalid. So this test can be removed.
Contributor
Author
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97, saad-ali The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
saad-ali
added
the
priority/critical-urgent
suneeth51
pushed a commit
to suneeth51/csi-test
that referenced
this pull request
Sep 11, 2019
Fix snapshot test
pohly
added a commit
to pohly/csi-test
that referenced
this pull request
Jan 26, 2021
1d60e77 Merge pull request kubernetes-csi#131 from pohly/kubernetes-1.20-tag 9f10459 prow.sh: support building Kubernetes for a specific version fe1f284 Merge pull request kubernetes-csi#121 from kvaps/namespace-check 8fdf0f7 Merge pull request kubernetes-csi#128 from fengzixu/master 1c94220 fix: fix a bug of csi-sanity a4c41e6 Merge pull request kubernetes-csi#127 from pohly/fix-boilerplate ece0f50 check namespace for snapshot-controller dbd8967 verify-boilerplate.sh: fix path to script 9289fd1 Merge pull request kubernetes-csi#125 from sachinkumarsingh092/optional-spelling-boilerplate-checks ad29307 Make the spelling and boilerplate checks optional 5f06d02 Merge pull request kubernetes-csi#124 from sachinkumarsingh092/fix-spellcheck-boilerplate-tests 48186eb Fix spelling and boilerplate errors 71690af Merge pull request kubernetes-csi#122 from sachinkumarsingh092/include-spellcheck-boilerplate-tests 981be3f Adding spelling and boilerplate checks. 2bb7525 Merge pull request kubernetes-csi#117 from fengzixu/master 3b6d17b Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout 9318c6c cloud build: double the timeout, now 1 hour 4ab8b15 use the tag to replace commit of csi-test 5d74e45 change the csi-test import path to v4 7dcd0a9 upgrade csi-test to v4.0.2 86ff580 Merge pull request kubernetes-csi#116 from andyzhangx/export-image-name c3a9662 allow export image name and registry name git-subtree-dir: release-tools git-subtree-split: 1d60e77
stmcginnis
pushed a commit
to stmcginnis/csi-test
that referenced
this pull request
Oct 9, 2024
allow export registry name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove snapshot invalid token test, modify the workflow for creating a
snapshot with the same name but different volume source id in order to
use valid volume id.