Skip to content

remove test case for starting_token when ListSnapshots #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Sep 22, 2018
Merged

remove test case for starting_token when ListSnapshots #115

k8s-ci-robot merged 2 commits into from
Sep 22, 2018

Conversation

@wackxu
Copy link
Contributor

@wackxu wackxu commented Sep 13, 2018

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 13, 2018

@wackxu: GitHub didn't allow me to assign the following users: xing-yang, jingxu97.

Note that only kubernetes-csi members and repo collaborators can be assigned.
For more information please see the contributor guide

Details

In response to this:

fix #114

/assign @lpabon @xing-yang @jingxu97

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 13, 2018
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2018
xing-yang
xing-yang reviewed Sep 13, 2018
View reviewed changes
Copy link
Contributor

@xing-yang xing-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xing-yang
Copy link
Contributor

xing-yang commented Sep 13, 2018

Please rebase.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 14, 2018
@wackxu
Copy link
Contributor Author

wackxu commented Sep 14, 2018

@xing-yang Rebased

xing-yang
xing-yang reviewed Sep 14, 2018
View reviewed changes
Copy link
Contributor

@xing-yang xing-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lpabon
Copy link
Member

lpabon commented Sep 22, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 22, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpabon, wackxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8424d42 into kubernetes-csi:master Sep 22, 2018
suneeth51 pushed a commit to suneeth51/csi-test that referenced this pull request Sep 11, 2019
@k8s-ci-robot
Merge pull request kubernetes-csi#115 from wackxu/rmtokentest
97d06af 
remove test case for starting_token when ListSnapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xing-yang xing-yang xing-yang left review comments

@lpabon lpabon Awaiting requested review from lpabon

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@lpabon lpabon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

remove test case for starting_token when ListSnapshots

4 participants

@wackxu @k8s-ci-robot @xing-yang @lpabon