ListSnapshot: support secrets

[pohly]

csi-test/pkg/sanity/sanity.go

Lines 39 to 51 in b9a7786

	// CSISecrets consists of secrets used in CSI credentials.
	type CSISecrets struct {
	CreateVolumeSecret map[string]string `yaml:"CreateVolumeSecret"`
	DeleteVolumeSecret map[string]string `yaml:"DeleteVolumeSecret"`
	ControllerPublishVolumeSecret map[string]string `yaml:"ControllerPublishVolumeSecret"`
	ControllerUnpublishVolumeSecret map[string]string `yaml:"ControllerUnpublishVolumeSecret"`
	ControllerValidateVolumeCapabilitiesSecret map[string]string `yaml:"ControllerValidateVolumeCapabilitiesSecret"`
	NodeStageVolumeSecret map[string]string `yaml:"NodeStageVolumeSecret"`
	NodePublishVolumeSecret map[string]string `yaml:"NodePublishVolumeSecret"`
	CreateSnapshotSecret map[string]string `yaml:"CreateSnapshotSecret"`
	DeleteSnapshotSecret map[string]string `yaml:"DeleteSnapshotSecret"`
	ControllerExpandVolumeSecret map[string]string `yaml:"ControllerExpandVolumeSecret"`
	}

does not have an entry for ListSnapshot and invocations of that function in https://github.com/kubernetes-csi/csi-test/blob/master/pkg/sanity/controller.go lack secrets.

This should be added because the spec allows it and drivers may need it.

/help

[k8s-ci-robot]

@pohly:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

Details

In response to this:

csi-test/pkg/sanity/sanity.go

Lines 39 to 51 in b9a7786

	// CSISecrets consists of secrets used in CSI credentials.
	type CSISecrets struct {
	CreateVolumeSecret map[string]string `yaml:"CreateVolumeSecret"`
	DeleteVolumeSecret map[string]string `yaml:"DeleteVolumeSecret"`
	ControllerPublishVolumeSecret map[string]string `yaml:"ControllerPublishVolumeSecret"`
	ControllerUnpublishVolumeSecret map[string]string `yaml:"ControllerUnpublishVolumeSecret"`
	ControllerValidateVolumeCapabilitiesSecret map[string]string `yaml:"ControllerValidateVolumeCapabilitiesSecret"`
	NodeStageVolumeSecret map[string]string `yaml:"NodeStageVolumeSecret"`
	NodePublishVolumeSecret map[string]string `yaml:"NodePublishVolumeSecret"`
	CreateSnapshotSecret map[string]string `yaml:"CreateSnapshotSecret"`
	DeleteSnapshotSecret map[string]string `yaml:"DeleteSnapshotSecret"`
	ControllerExpandVolumeSecret map[string]string `yaml:"ControllerExpandVolumeSecret"`
	}

does not have an entry for ListSnapshot and invocations of that function in https://github.com/kubernetes-csi/csi-test/blob/master/pkg/sanity/controller.go lack secrets.

This should be added because the spec allows it and drivers may need it.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pohly]

/lifecycle frozen

[jskazinski]

Just letting other knows, I have made changes to address this issue and I am working on a pull request. My ListSnapshots tests are now getting the correct secrets.