Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create common library for rpc connection logic #6

Closed
msau42 opened this issue Dec 11, 2018 · 5 comments
Closed

Create common library for rpc connection logic #6

msau42 opened this issue Dec 11, 2018 · 5 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@msau42
Copy link
Collaborator

msau42 commented Dec 11, 2018

Currently all the sidecars copy paste the same connection logic

/help
@k8s-ci-robot
Copy link
Contributor

@msau42:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Currently all the sidecars copy paste the same connection logic

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Dec 11, 2018
@darkowlzz
Copy link
Contributor

darkowlzz commented Dec 24, 2018 •
edited
Loading

Hi, I would like to work on this.
I guess it just needs moving the connection package with all the functions from other sidecars to this repo and then update all the sidecars to import connection from this project.

@darkowlzz darkowlzz mentioned this issue Dec 24, 2018
Closed
@msau42 msau42 mentioned this issue Jan 16, 2019
Closed
@jsafrane
Copy link
Contributor

jsafrane commented Feb 7, 2019

Fixed by #11

@jsafrane
Copy link
Contributor

jsafrane commented Feb 7, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@jsafrane: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@darkowlzz @jsafrane @k8s-ci-robot @msau42