Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProbeForever has 1 second delay #177

Closed
jsafrane opened this issue May 31, 2024 · 3 comments · Fixed by #175, kubernetes/k8s.io#6863 or openshift/csi-external-snapshotter#156
Closed

ProbeForever has 1 second delay #177

jsafrane opened this issue May 31, 2024 · 3 comments · Fixed by #175, kubernetes/k8s.io#6863 or openshift/csi-external-snapshotter#156

Comments

@jsafrane
Copy link
Contributor

Originally reported by @Fricounet in #175.

The previous beheavior of ProbeForever was to try a probe and then sleep for the probeInterval duration. When it was modified to use a time.Ticker instead of a sleep in #149, it changed the behavior to wait the probeInterval first and then do the probe.

This adds unnecessary 1 second delay for the first Probe() call.

@jsafrane
Copy link
Contributor Author

/close

This is fixed by #177. I'm using this issue to track what CSI sidecars need update.

@k8s-ci-robot
Copy link
Contributor

@jsafrane: Closing this issue.

In response to this:

/close

This is fixed by #177. I'm using this issue to track what CSI sidecars need update.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jsafrane
Copy link
Contributor Author

jsafrane commented May 31, 2024

Needs update + patch release, because they use ProbeForever:

Does not use ProbeForever:

  • livenessprobe
  • node-driver-registrar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants