Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove createSubDir parameter #295

Merged
merged 1 commit into from
Jun 3, 2021
Merged

feat: remove createSubDir parameter #295

merged 1 commit into from
Jun 3, 2021

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jun 3, 2021 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: remove createSubDir parameter since it's redundant, it all depends on whether provisioner-secret is provided

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

feat: remove createSubDir parameter

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 3, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 3, 2021
@andyzhangx andyzhangx force-pushed the remove-createsubdir branch 2 times, most recently from 4d61b4e to d97bb13 Compare June 3, 2021 01:53
@andyzhangx
feat: remove createSubDir parameter
5adf884 
fix golint

fix spelling

test: fix integration test failure
@andyzhangx andyzhangx force-pushed the remove-createsubdir branch from d97bb13 to 5adf884 Compare June 3, 2021 02:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 901344650

  • 15 of 18 (83.33%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 86.805%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/smb/controllerserver.go 15 18 83.33%
Files with Coverage Reduction New Missed Lines %
pkg/smb/controllerserver.go 5 88.6%
Totals Coverage Status
Change from base Build 901234149: 0.3%
Covered Lines: 796
Relevant Lines: 917
💛 - Coveralls

boddumanohar
boddumanohar approved these changes Jun 3, 2021
View reviewed changes
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, boddumanohar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andyzhangx andyzhangx merged commit 187b281 into kubernetes-csi:master Jun 3, 2021
@steveizzle steveizzle mentioned this pull request Jun 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boddumanohar boddumanohar boddumanohar approved these changes

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andyzhangx @coveralls @k8s-ci-robot @boddumanohar