Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kube dependencies to v1.25.0 #137

Merged
merged 13 commits into from
Sep 7, 2022

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Aug 24, 2022

Signed-off-by: Humble Chirammal hchiramm@redhat.com

/kind cleanup

This release update kubernetes dependencies to v1.25.0

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 24, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 24, 2022
@humblec humblec force-pushed the kube-1.25 branch 2 times, most recently from a206859 to 171069b Compare August 24, 2022 05:58
@humblec humblec force-pushed the kube-1.25 branch 3 times, most recently from c8eb591 to 538cfca Compare September 3, 2022 04:03
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec humblec force-pushed the kube-1.25 branch 4 times, most recently from bd2eb57 to c688650 Compare September 5, 2022 04:25
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
7f4f7cc Merge pull request kubernetes-csi#39 from humblec/new-changes
8566b12 iscsi library fixes based on the csi-driver-iscsi
c7bdbc5 Merge commit '706bbe0f1f5d43be335f2439f05fc15a8c372f32' into make-sync
676c6e5 Merge commit '67e5053588f954d534c3fae7f9d65116f0baee43' into make-sync
bb8cceb chore: fix gofmt
57f5817 add codespell linter to the github workflow actions
f6582f6 update: pick latest kube release for alpha version
30b6cf3 various linter corrections and code cleanup
ad94dad correct codespell errors in the imported library

git-subtree-dir: pkg/lib/iscsi
git-subtree-split: 7f4f7cc2448e7181a5dec97b20acf5ec28c32c16
d24254f Merge pull request kubernetes-csi#202 from xing-yang/kind_0.14.0
0faa3fc Update to Kind v0.14.0 images
ef4e1b2 Merge pull request kubernetes-csi#201 from xing-yang/add_1.24_image
4ddce25 Add 1.24 Kind image
7fe5149 Merge pull request kubernetes-csi#200 from pohly/bump-kubernetes-version
70915a8 prow.sh: update snapshotter version
31a3f38 Merge pull request kubernetes-csi#199 from pohly/bump-kubernetes-version
7577454 prow.sh: bump Kubernetes to v1.22.0

git-subtree-dir: release-tools
git-subtree-split: d24254f
ce26141 Merge pull request kubernetes-csi#40 from humblec/dep-update
46a11db update dependencies and go version

git-subtree-dir: pkg/lib/iscsi
git-subtree-split: ce2614163c72a5358a3f24e839ce55ff6f0a30c9
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Copy link
Contributor Author

humblec commented Sep 6, 2022

The failed tests are passing locally:

[hchiramm@hchiramm csi-driver-iscsi]$ make test
Makefile:48: warning: overriding recipe for target 'clean'
release-tools/build.make:220: warning: ignoring old recipe for target 'clean'
./release-tools/verify-go-version.sh "go"

======================================================
                  WARNING

  This projects is tested with Go v1.18.
  Your current Go version is v1.19.
  This may or may not be close enough.

  In particular test-gofmt and test-vendor
  are known to be sensitive to the version of
  Go.
======================================================


### test-go:
go test  `go list  ./... | grep -v -e 'vendor' -e '/test/e2e$' ` 
?   	github.com/kubernetes-csi/csi-driver-iscsi/cmd/iscsiplugin	[no test files]
?   	github.com/kubernetes-csi/csi-driver-iscsi/pkg/iscsi	[no test files]
?   	github.com/kubernetes-csi/csi-driver-iscsi/release-tools	[no test files]

### test-vet:
go vet  `go list  ./... | grep -v vendor `

### test-fmt:
files=$(find . -name '*.go' | grep -v './vendor' ); \
if [ $(gofmt -d $files | wc -l) -ne 0 ]; then \
	echo "formatting errors:"; \
	gofmt -d $files; \
	false; \
fi

### test-vendor:
Repo uses 'go mod'.
+ env GO111MODULE=on go mod tidy
+ env GO111MODULE=on go mod vendor
Go dependencies and vendor directory up-to-date.

### test-subtree:
./release-tools/verify-subtree.sh release-tools
release-tools is a clean copy of upstream.

### test-shellcheck:
/usr/bin/docker

/home/hchiramm/go/src/github.com/kubernetes-csi/csi-driver-iscsi/release-tools:
Using shellcheck 0.6.0 docker image.
Congratulations! All shell files are passing lint.
[hchiramm@hchiramm csi-driver-iscsi]$ make test-vendor 
Makefile:48: warning: overriding recipe for target 'clean'
release-tools/build.make:220: warning: ignoring old recipe for target 'clean'

### test-vendor:
Repo uses 'go mod'.
+ env GO111MODULE=on go mod tidy
+ env GO111MODULE=on go mod vendor
Go dependencies and vendor directory up-to-date.
[hchiramm@hchiramm csi-driver-iscsi]$ 

These are the errors in the CI:


### test-go:
go test -mod=vendor `go list -mod=vendor ./... | grep -v -e 'vendor' -e '/test/e2e$' ` 
?   	github.com/kubernetes-csi/csi-driver-iscsi/cmd/iscsiplugin	[no test files]
?   	github.com/kubernetes-csi/csi-driver-iscsi/pkg/iscsi	[no test files]
?   	github.com/kubernetes-csi/csi-driver-iscsi/release-tools	[no test files]

### test-vet:
go vet -mod=vendor `go list -mod=vendor ./... | grep -v vendor `

### test-fmt:
files=$(find . -name '*.go' | grep -v './vendor' ); \
if [ $(gofmt -d $files | wc -l) -ne 0 ]; then \
	echo "formatting errors:"; \
	gofmt -d $files; \
	false; \
fi

### test-vendor:
Repo uses 'go mod'.
+ env GO111MODULE=on go mod tidy
go: go.mod file indicates go 1.19, but maximum version supported by tidy is 1.18
ERROR: vendor check failed.
make: *** [release-tools/build.make:279: test-vendor] Error 1

### test-subtree:
./release-tools/verify-subtree.sh release-tools
release-tools is a clean copy of upstream.

### test-shellcheck:
/usr/bin/docker

/home/prow/go/src/github.com/kubernetes-csi/csi-driver-iscsi/release-tools:
Using shellcheck 0.6.0 docker image.
Congratulations! All shell files are passing lint.
make: Target 'test' not remade because of errors.
ERROR: 'make test' failed
WARNING: 'make test' failed, proceeding anyway
Tue Sep  6 05:57:25 UTC 2022 go1.18 $

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, humblec

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d90de40 into kubernetes-csi:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants