Remove --kube-root deprecated kind argument #554
Conversation
The --kube-root flag has been deprecated in kind for some time and will be removed. The current equivalent functionality is to pass the path to the kubernetes source as the first non-flag argument to "build node-image". This updates the prow script to use the newer preferred method in preparation for kind dropping the flag. Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
k8s-ci-robot
added
release-note-none
|
Welcome @stmcginnis! |
|
Hi @stmcginnis. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-ok-to-test
k8s-ci-robot
added
the
size/XS
|
/assign @pohly |
| @@ -621,7 +621,7 @@ start_cluster () { | |||
| go_version="$(go_version_for_kubernetes "${CSI_PROW_WORK}/src/kubernetes" "$version")" || die "cannot proceed without knowing Go version for Kubernetes" | |||
| # Changing into the Kubernetes source code directory is a workaround for https://github.com/kubernetes-sigs/kind/issues/1910 | |||
| # shellcheck disable=SC2046 | |||
| (cd "${CSI_PROW_WORK}/src/kubernetes" && run_with_go "$go_version" kind build node-image --image csiprow/node:latest --kube-root "${CSI_PROW_WORK}/src/kubernetes") || die "'kind build node-image' failed" | |||
| (cd "${CSI_PROW_WORK}/src/kubernetes" && run_with_go "$go_version" kind build node-image "${CSI_PROW_WORK}/src/kubernetes" --image csiprow/node:latest) || die "'kind build node-image' failed" | |||
There was a problem hiding this comment.
Please make the same change in https://github.com/kubernetes-csi/csi-release-tools/. That repo gets mirrored into the different CSI sidecard repos semi-automatically.
There was a problem hiding this comment.
Thanks @pohly - I didn't realize that until I had done a few of these, but there is a PR pending there as well. It looks like that repo's jobs are broken right now though, and I'm not familiar enough with it to investigate why. I've brought it up on a couple of these PRs, but if there's anyone specific to poke to try to get things moving again, just let me know.
|
@TerryHowe: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stmcginnis, TerryHowe The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The
--kube-rootflag has been deprecated in kind for some time and will be removed. The current equivalent functionality is to pass the path to the kubernetes source as the first non-flag argument tobuild node-image.This updates the prow script to use the newer preferred method in preparation for kind dropping the flag.
Which issue(s) this PR fixes:
Related: kubernetes-sigs/kind#3717
Special notes for your reviewer:
Does this PR introduce a user-facing change?: