Remove unused scripts in hack/ directory

[chrishenzie]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Removes the hack/ directory because the scripts inside it are unused.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@pohly @xing-yang

[chrishenzie]

It looks like this URL doesn't work anymore, we'll need to change how we fetch the csi-sanity binary

[pohly]

It looks like this URL doesn't work anymore, we'll need to change how we fetch the csi-sanity binary

Just build it with go install. But where is hack/get-sanity.sh used? Should we perhaps remove it entirely?

The Prow jobs install it through code in prow.sh, which comes from csi-release-tools:
https://github.com/kubernetes-csi/csi-release-tools/blob/4aedf357cac90c044cf3c2b8ff189520e3fd37b2/prow.sh#L231-L241

[andyzhangx]

@pohly so this sanity test suite does not work?
I set up sanity test in nfs repo like this, maybe we should switch to this way?
https://github.com/kubernetes-csi/csi-driver-nfs/blob/master/test/sanity/run-test.sh

[pohly]

prow.sh works just fine for csi-sanity, no need to change anything there.

What would need further work is hack/get-sanity.sh but as it is unused (?) we perhaps should better remove it.

[chrishenzie]

Thanks for catching that. I'll update the CSI sanity test suite here: kubernetes-csi/csi-release-tools#182

[chrishenzie]

Repurposed this PR to remove the unused scripts in the hack/ directory.

Edit: I had also removed bump-image-versions.sh but I suspect we may need this

[mauriciopoppe]

Edit: I had also removed bump-image-versions.sh but I suspect we may need this

yeah, there might be some scripts that aren't called from this repo but that are called from other repos like test-infra, I saw the same in local volume provisioner so it might be worth looking into the test-infra config jobs too

[pohly]

I had also removed bump-image-versions.sh but I suspect we may need this

Correct. I can be invoked manually to update the YAML files. If that wasn't clear, then adding a section for it under "repository maintenance" or "development" might help to avoid future confusion.

[chrishenzie]

Updated script to exclude paths for Kubernetes 1.19 and 1.20. Please let me know if this is aligned with your expectations.

[pohly]

/lgtm

I'll leave approval to @xing-yang.

[pohly]

/cancel lgtm

Documentation still needs to be updated.

[pohly]

/lgtm cancel

[chrishenzie]

@pohly Can you help me to understand what documentation changes we want to make?

From my understanding, we just need to delete any pre-1.17 markdown docs. Is this correct?

[xing-yang]

There are still a few places in the top level README that need to be updated. For example:
https://github.com/kubernetes-csi/csi-driver-host-path/tree/v1.7.3#deployment

[chrishenzie]

@xing-yang Updated README to remove references to docs for 1.16 and earlier.

[chrishenzie]

@xing-yang @pohly Updated documentation. Please let me know if there are any other doc changes you would like included here.

[xing-yang]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrishenzie, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[xing-yang]

@chrishenzie We missed updating the snapshot image.
Can you submit a follow-up PR to update the csi-snapshotter image to k8s.gcr.io/sig-storage/csi-snapshotter:v5.0.1?
https://github.com/kubernetes-csi/csi-driver-host-path/blob/master/deploy/kubernetes-1.21/hostpath/csi-hostpath-plugin.yaml#L357