Fixed block volume snapshots #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"tar xvfz <snapshot> -C <dst>" does not work for block volumes, because <dst> is not a directory but a block file. Reworked to use tar only for filesystem snapshots and simple cp/dd for block snapshots. As consequence, snapshot suffix is now ".snap" instead of ".tgz".
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/S
|
@msau42 @xing-yang @pohly, PTAL |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Do we support upgrading/restarting the hostpath driver and it being able to restore from previous snapshots? If so we should update the release note to say it's a breaking change |
|
Not yet, but see #161 |
TerryHowe
pushed a commit
to TerryHowe/csi-driver-host-path
that referenced
this pull request
Oct 17, 2024
…ommand prow.sh: allow shell commands in CSI_PROW_SANITY_POD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tar xvfz <snapshot> -C <dst>does not work for block volumes, because<dst>is not a directory but a block file.Reworked to use
taronly for filesystem snapshots and simplecp/ddfor block snapshots. As consequence, snapshot suffix is now ".snap" instead of ".tgz"./kind bug
Which issue(s) this PR fixes:
Helps with #88726
Does this PR introduce a user-facing change?: