Skip to content
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# v11.0.0a1
**New Feature:**
- Add dynamic client [kubernetes-client/python-base#56](https://github.com/kubernetes-client/python-base/pull/56)

# v10.0.0
**Bug Fix:**
- Fix base64 padding for kube config [kubernetes-client/python-base#79](https://github.com/kubernetes-client/python-base/pull/79)
Expand Down
2 changes: 1 addition & 1 deletion kubernetes/base
7 changes: 7 additions & 0 deletions scripts/update-client.sh
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,13 @@ if [[ -z ${GEN_ROOT:-} ]]; then
GEN_ROOT="${TEMP_FOLDER}/gen"
echo ">>> Cloning gen repo"
git clone --recursive https://github.com/kubernetes-client/gen.git "${GEN_ROOT}"
# pick https://github.com/kubernetes-client/gen/pull/97
cd "${GEN_ROOT}"
git remote add tomplus https://github.com/tomplus/gen.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a personal repo. does openapi generator have an official repo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Roy is trying to pick the kubernetes-client/gen changes by tomplus

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not merge this kubernetes-client/gen#97 it first?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked with @yliaog offline. This is picking kubernetes-client/gen#97 into gen repo before we have it approved and merged. Timing-wise I can go with having this pick for the alpha release. For beta release we should definitely use upstream gen with kubernetes-client/gen#97 merged

git fetch tomplus
# somehow I couldn't get a clean cherrypick of the commit
git checkout tomplus/feat/python-openapi-generator
cd "${SCRIPT_ROOT}"
else
echo ">>> Reusing gen repo at ${GEN_ROOT}"
fi
Expand Down