added async_req parameter (default to True) to ApiClient constructor #473
Conversation
| } | ||
|
|
||
| def __init__(self, configuration=None, header_name=None, header_value=None, cookie=None): | ||
| def __init__(self, configuration=None, header_name=None, header_value=None, cookie=None, async_req=True): |
There was a problem hiding this comment.
This file is auto-generated by swagger-codegen. You could contribute to swagger-codegen python template. When you did, we can import the changes here. Ref: #226
There was a problem hiding this comment.
@roycaihw sure, can migrate the code change there, but other than that, the code looks ok?
There was a problem hiding this comment.
the code change makes sense to me, although I'm not a python expert :)
There was a problem hiding this comment.
I created the PR here: swagger-api/swagger-codegen#7782
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
cncf-cla: yes
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
lifecycle/rotten
|
It looks like the upstream fix was stale. We recently bumped our dependency to use up-to-date upstream generator #931. If this issue has been fixed upstream, we should have picked the fix up /close |
|
@roycaihw: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
Taking a stab at issue #471
@dims ptal