Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the refreshing of tokens from outside the cluster #1947

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Fix the refreshing of tokens from outside the cluster #1947

merged 1 commit into from
Jan 16, 2023

Conversation

AlexisZam
Copy link

What type of PR is this?

/kind bug

What this PR does / why we need it:

Requests from outside the cluster may have stale tokens and fail with status code 401.

Which issue(s) this PR fixes:

Fixes #1946

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Fix the refreshing of tokens from outside the cluster
a07531b 
Requests from outside the cluster may have stale tokens and fail with
status code `401`.

Signed-off-by: Alexis Zamanis <alexiszam@arrikto.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Nov 8, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 8, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: AlexisZam / name: Alexis Zamanis (a07531b)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 8, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @AlexisZam!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 8, 2022
@roycaihw
Copy link
Member

roycaihw commented Dec 5, 2022

/assign @yliaog

@yliaog
Copy link
Contributor

yliaog commented Jan 16, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexisZam, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8f80cf4 into kubernetes-client:master Jan 16, 2023
@AlexisZam AlexisZam deleted the feature-out-of-cluster-token-refresh branch January 17, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianvf fabianvf Awaiting requested review from fabianvf

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requests from outside the cluster may have stale tokens and fail with status code 401
4 participants
@AlexisZam @k8s-ci-robot @roycaihw @yliaog