Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaderelection.resourcelock not found #1631

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Fix leaderelection.resourcelock not found #1631

merged 1 commit into from
Nov 30, 2021

Conversation

tdihp
Copy link
Contributor

@tdihp tdihp commented Nov 24, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

The kubernetes package provided in pypi doesn't include kubernetes.leaderelection.resourcelock in the package manifest of setup.py, this causes import failures.

Which issue(s) this PR fixes:

#1475 (not marking as Fixes, as it needs an additional base PR to entirely fix to be able to run example.py successfully)

Special notes for your reviewer:

n/a

Does this PR introduce a user-facing change?

No.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None.

@tdihp
Fix leaderelection.resourcelock not found
c8f1392 
Signed-off-by: Ping He <tdihp@hotmail.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 24, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @tdihp!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@tdihp
Copy link
Contributor Author

tdihp commented Nov 24, 2021

/hold

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 24, 2021
@tdihp tdihp mentioned this pull request Nov 24, 2021
Merged
@yliaog
Copy link
Contributor

yliaog commented Nov 29, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tdihp, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2021
@yliaog
Copy link
Contributor

yliaog commented Nov 29, 2021

/hold

@yliaog
Copy link
Contributor

yliaog commented Nov 30, 2021

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 30, 2021
@yliaog
Copy link
Contributor

yliaog commented Nov 30, 2021

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit c21a79f into kubernetes-client:master Nov 30, 2021
@tyrken tyrken mentioned this pull request Mar 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdihp @k8s-ci-robot @yliaog