Removed custom_object.py and created a new file namespaced_custom_object.py which is more specific to usage of namespaced custom resource

[Yashks1994]

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:

Removed the custom_object.py and created a new file as namespaced_custom_object.py which is more specific to usage of namespaced custom resource.

Which issue(s) this PR fixes:

Fixes #1438

[roycaihw]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, Yashks1994

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [roycaihw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Yashks1994]

/release-note-none

[Priyankasaggu11929]

~@Yashks1994, just a note.

Git takes renaming of the file with name custom_object.py to namespaced_custom_object.py as two steps:

• deleting the file custom_object.py
• and creating a new file namespaced_custom_object.py having the same contents as above.

To reflect the deletion of file custom_object.py, you need to add the deleted file as well in your git staging & then commit both the deleted file & new file.

Doing that, in the Files changed section of this PR, both the deleted file (custom_object.py) & new file (namespaced_object.py) will reflect.

Ok, I misunderstood the file renaming with the file deletion part. The file renaming would look something like this in the PR's Files Changed section.

Sorry for the trouble. (And I learnt this new thing. :) )

[Yashks1994]

@roycaihw needs your /lgtm as CI build passed.

[roycaihw]

The file renaming would look something like this in the PR's Files Changed section.

@Priyankasaggu11929 I was surprised when I saw that the first time. I didn't expect Github to render it that way but it's really beautiful.

@Yashks1994 LGTM. Please squash the commits as I suggested in #1439 (comment):

• one commit for adding patch example to custom_object.py
• one commit for renaming the file to namespaced_custom_object.py

[roycaihw]

why do we have a commit that reverse the order of patch_namespaced_custom_object and delete_namespaced_custom_object?

[roycaihw]

https://github.com/kubernetes-client/python/pull/1444/commits is what I was asking for, if that makes sense

[Yashks1994]

I kept the order like this,
we have create, get, patch, delete

[roycaihw]

currently the two PRs have the same code change, but the commits are different

Commits should represent meaningful milestones or units of work. Currently the commits in this PR are:

• your first commit renames the file and adds a patch method after the delete method, which means the example has a bug and will run into an error
• your second commit reverses the order of the patch method and the delete method to fix the bug in the first commit

please take a look at https://github.com/kubernetes/community/blob/master/contributors/guide/github-workflow.md#squash-commits. The second commit is a "Work in progress" (it fixes a bug in the first commit during development), so please squash it.

again, I think having two commits like the following will be most reasonable and readable:

• one commit for adding patch example to custom_object.py
• one commit for renaming the file to namespaced_custom_object.py

at this point I'm also okay with having just one commit, which will be more reasonable than the current two commits in this PR

[Yashks1994]

I am keeping the one commit and with proper commit message.

[k8s-ci-robot]

@Yashks1994: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[roycaihw]

Thanks!
/lgtm