fixed issues related to TLS verification. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JohnCMcDonough LGTM. Please sign the CLA and then we can merge this! |
|
Alright, I've signed the agreement! At least, I think I have... |
|
CLA still shows as missing, is your email associated with your github the same as what you signed from? |
|
(also now needs a rebase...) |
|
Is this CLA being taken care of? My workaround was making the kube config key value be a string, but then |
|
This PR is now obsolete, since the requirement for CA cert was removed. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found two issues related to TLS verification.
Originally, the check relied on "falsy" conversions that were invalid.
elt.cluster['insecure-skip-tls-verify'] == 'true'where
elt.cluster['insecure-skip-tls-verify']was a boolean, and'true'was a string.true == 'true'is false.The other issue, is that it expected
certificate-authority-dataandcertificate-authorityeven ifskipTLSVerifywas true.