Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse insecure-skip-tls-verify correctly #54

Merged
merged 1 commit into from
Jul 9, 2018
Merged

fix: parse insecure-skip-tls-verify correctly #54

merged 1 commit into from
Jul 9, 2018

Conversation

edvald
Copy link
Contributor

@edvald edvald commented Jun 7, 2018

A simple fix and test. The YAML parser will return the value as a boolean, so the comparison was incorrect.

@brendandburns
Copy link
Contributor

@edvald Thanks for the PR! we need a signed CLA to merge.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 18, 2018
@edvald
Copy link
Contributor Author

edvald commented Jun 18, 2018

Sure thing! I signed it last week, should be all set.

@brendandburns
Copy link
Contributor

Thanks, LGTM!

@brendandburns brendandburns merged commit 1dba6fd into kubernetes-client:master Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edvald @brendandburns @k8s-ci-robot