-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused index.ts file at root of package #25
Remove unused index.ts file at root of package #25
Conversation
52db687
to
6735fac
Compare
This seems to resolve the issue. However, the
Unless I'm missing something, the way to go is to copy the package.json to the dist directory and run the
For this, to work we need to change the build project to run |
@jonathansant Thanks for looking into this! I think there's definitely something weird going on, but I don't think it's necessary to move the package.json into the What I did instead is update the
...which I think is totally normal. When you use
this should now correctly import Please try it out and let me know if it works for you. |
I would love to see this get shipped soon if at all possible. I am currently up against the same issue. Is there a work around for the current release? |
@abedra What I've been doing is just forking the repo and hosting the fixed version as a repo on github. I have an example here: https://github.com/cjlarose/javascript/tree/package You can install with
Though you'll probably want to make your own fork. My fork's got some stuff in it that might not get merged upstream. |
@cjlarose sorry for the delayed response. I tried this and it worked just fine. I'm no authority over this repo but you can merge this PR. Thanks for your help. |
LGTM, thanks for the fix, will push this up soon. |
This causes compiler errors when trying to import the package in a typescript project
I describe this in better detail here: #23 (comment)
Closes #23