-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not close whole websocket when v5 protocol is supported #2115
base: master
Are you sure you want to change the base?
Do not close whole websocket when v5 protocol is supported #2115
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CGNonofr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @CGNonofr! |
Thank you for the fix! This should probably be ported to |
Also we need you to sign the CLA. |
I looks like a really heavy process for a so small change, I'm not sure I want to provide my mailing address either. I authorize you to close that PR and open one of yours with the fix! |
Recently the v5.channel.k8s.io was implemented allowing to close exec streams.
But the close still closes the whole websocket when the stdin is closed