-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset resource version #1934
Reset resource version #1934
Conversation
Welcome @feloy! |
231ab5d
to
c1e00b8
Compare
/lgtm Bonus points if you add a unit test for this :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, feloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
afaae2c
into
kubernetes-client:release-1.0.0-rc6.1
Should this land on any branches other than |
@cjihrig AFAIK it's only reproduced in 1.x, not in 0.x it would be interesting to have a new version published to npmjs 🙏 |
I guess my question is, should this change also land on the |
ah yes from consumer POV it seems it should be in that branch as well 👍 |
How do we proceed? Do I create another PR on the |
Hey @feloy I just saw this. |
…esourceVersion Reset resource version
Unit tests with #1936 |
Reset the resourceVersion when the watcher receives an error 410
Fixes #1933