Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset resource version #1934

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Oct 14, 2024

Reset the resourceVersion when the watcher receives an error 410

Fixes #1933

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @feloy!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2024
@feloy feloy force-pushed the fix-1933/reset-resourceVersion branch from 231ab5d to c1e00b8 Compare October 14, 2024 19:33
@brendandburns
Copy link
Contributor

/lgtm
/approve

Bonus points if you add a unit test for this :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit afaae2c into kubernetes-client:release-1.0.0-rc6.1 Oct 14, 2024
1 of 2 checks passed
@cjihrig
Copy link
Contributor

cjihrig commented Oct 14, 2024

Should this land on any branches other than release-1.0.0-rc6.1?

@benoitf
Copy link

benoitf commented Oct 14, 2024

@cjihrig AFAIK it's only reproduced in 1.x, not in 0.x

it would be interesting to have a new version published to npmjs 🙏

@cjihrig
Copy link
Contributor

cjihrig commented Oct 14, 2024

AFAIK it's only reproduced in 1.x, not in 0.x

I guess my question is, should this change also land on the release-1.x branch?

@benoitf
Copy link

benoitf commented Oct 14, 2024

ah yes from consumer POV it seems it should be in that branch as well 👍

@feloy
Copy link
Contributor Author

feloy commented Oct 15, 2024

How do we proceed? Do I create another PR on the release-1.x branch?

@mstruebing
Copy link
Member

Hey @feloy I just saw this.
Yes, this needs to land in release-1.x branch to be considered in upcoming releases.
If you push something into an existing branch/tag it will only considered for patch releases to that specific version.

feloy pushed a commit to feloy/kubernetes-client-javascript that referenced this pull request Oct 15, 2024
This was referenced Oct 15, 2024
@feloy
Copy link
Contributor Author

feloy commented Oct 15, 2024

Bonus points if you add a unit test for this :)

Unit tests with #1936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants