Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library to 1.9.x #17

Merged
merged 2 commits into from
Mar 24, 2018

Conversation

brendandburns
Copy link
Contributor

No description provided.

@hausdorff
Copy link

Any chance we could also apply the trivial changes I suggest in #13 to fix --strict incompatibility while we're at it? It should be 2 lines in package.json.

@brendandburns
Copy link
Contributor Author

@hausdorff Does that look right?

Thanks
--brendan

@hausdorff
Copy link

@brendandburns Unless I'm missing something, I think it should be prefaced by a dist/, e.g., "dist/index.js":

So, altogether:

@@ -10,7 +10,8 @@
     "*.ts",
     "*.js"
   ],
-  "main": "index.js",
+  "main": "dist/index.js",
+  "types": "dist/index.d.ts",
   "scripts": {
     "clean": "rm -Rf node_modules/ dist/",
     "build": "tsc",

@brendandburns
Copy link
Contributor Author

Ok, I fixed it. There were some problems with the package.json and building the npm also, this all seems to work correctly now...

@brendandburns brendandburns merged commit 397ca8f into kubernetes-client:master Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants