Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to the typescript generated client. #1

Merged
merged 2 commits into from
Dec 18, 2017

Conversation

brendandburns
Copy link
Contributor

@brendandburns brendandburns commented Dec 14, 2017

Will deprecate the typescript repository once this is merged.

Add examples for how to use typescript from javascript.
Update documentation.
@brendandburns
Copy link
Contributor Author

@mbohlool

@mbohlool
Copy link
Contributor

mbohlool commented Dec 15, 2017

@brendandburns I would be fine with this solution. Another approach we can take is to rename typescript client to javascript and have typescript and javascript examples there. Typescript would be the language we use to implement javascript client. I like that approach more. WDYT?

@brendandburns
Copy link
Contributor Author

brendandburns commented Dec 15, 2017 via email

@brendandburns brendandburns changed the title Remove the javascript generated client. Switch to the typescript generated client. Dec 16, 2017
@brendandburns
Copy link
Contributor Author

Ok, PR updated to add in the typescript client here.

I will deprecate the typescript-only repo once this PR is merged.

@brendandburns
Copy link
Contributor Author

@mbohlool friendly monday morning ping (assuming you're not on vacation... If you are, please ignore :)

@mbohlool
Copy link
Contributor

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants