No package.json

[svenefftinge]

There is no package.json.

[brendandburns]

There's a package.json here:

https://github.com/kubernetes-client/javascript/blob/master/node/package.json

I don't think we need a top-level one, do we?

[svenefftinge]

ok, it's a little uncommon, though. so you might see more people asking about it.

[brendandburns]

The motivation was because I want both a lib and an examples directory and I didn't want to have my examples inside my lib. How do other projects handle that kind of thing?

Thanks!

[svenefftinge]

It would make sense to me if there were different package.json for the code and the examples, but I only see one package.json. You can specify in package.json that examples should not be published.

But the confusion for me might have been caused by the ts files sitting in the same directory as the package.json. They usually sit in some sort of source folder, so you can separate them from .js and .d.ts files. And the package.json in the parent.

[brendandburns]

I'm definitely new to packaging a TS library, if you have pointers to canonical examples, I'm happy to re-factor the directory layout. Thanks!

…

________________________________________ From: Sven Efftinge <notifications@github.com> Sent: Monday, January 8, 2018 12:35 PM To: kubernetes-client/javascript Cc: Brendan Burns; Comment Subject: Re: [kubernetes-client/javascript] No package.json (#3) It would make sense to me if there were different package.json for the code and the examples, but I only see one package.json. You can specify in package.json that examples should not be published. But the confusion for me might have been caused by the ts files sitting in the same directory as the package.json. They usually sit in some sort of source folder, so you can separate them from .js and .d.ts files. And the package.json in the parent. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubernetes-client%2Fjavascript%2Fissues%2F3%23issuecomment-356088061&data=02%7C01%7Cbburns%40microsoft.com%7C539281191395498fa0b708d556d751d6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636510405143215501&sdata=nqGvzyHDI0S0kSBjwEeulu6s1QZ%2FhywU4BdRsWksZWM%3D&reserved=0>, or mute the thread<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFfDghU0tOJ4LPeaod13sk8s2WdTM4dxks5tInv_gaJpZM4RRcQE&data=02%7C01%7Cbburns%40microsoft.com%7C539281191395498fa0b708d556d751d6%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636510405143215501&sdata=LzxUfSXYpqqbEZ%2BVHQS7jyTPAVeOHo1vBQ%2B%2Bf%2FMMLLE%3D&reserved=0>.

[svenefftinge]

It was easier to just make a proposal, than explaining it :)
#4

Feel free to take anything you find useful and please ask if you have questions.