-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#238: support client.authentication.k8s.io/v1beta1 ExecCredential #512
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
28b1732
Draft implementation of #238: support client.authentication.k8s.io/v1…
jglick d177116
Extracted method with multiple return values for clarity.
jglick 0bc22e6
Struggling to stay within the 100-column limit.
jglick 0f8c548
https://issues.apache.org/jira/browse/SUREFIRE-1226 can interfere wit…
jglick 0c3ca98
Initial test of exec credentials.
jglick a4163e2
Handle environment variables.
jglick 2d22dce
Honoring basedir for relative command paths.
jglick 558864f
Also handle client.authentication.k8s.io/v1alpha1.
jglick b2f9332
Verify .kind & .apiVersion.
jglick 93b87f4
Added debug statement to confirm that a token was at last obtained.
jglick f843269
Broader interpretation of “relative command path”.
jglick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Handle environment variables.
- Loading branch information
commit a4163e252326f84bcd73daf191ab3678adcd3a93
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why swallow the exception here? wouldn't you rather throw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not swallowed—it is sent to the log.
As to whether it is appropriate to throw exceptions out of
getAccessToken
(presumably wrapped inRuntimeException
?) as opposed to logging and proceeding with other authentication modes and ultimately returning null (unauthenticated), I have no strong opinion. I was following the example of existing code which proceeds despite errors (Failed to read token file
for example).On the other hand
AzureActiveDirectoryAuthenticator.refresh
appears to throw an undeclared exception out ofgetAccessToken
.KubeconfigAuthentication.<init>
is permitted to throwIOException
so perhapsgetAccessToken
should as well? That would mean reworking some existing code which catches and logs exceptions, and addingIOException
to the signature ofAuthenticator.refresh
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, sounds like it's messy, let's take it as a follow-on cleanup exercise...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted in PR description.