-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump okhttp to v3 #483
bump okhttp to v3 #483
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tedli If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3beff1e
to
fc5cdd5
Compare
|
/assign @mbohlool |
Sadly this code is all auto-generated, we can't make manual changes in this code since we won't be able to regenerate it as the Kubernetes API changes. The right path here is to regenerate the code to use something like feign instead of okhttp. It's a TODO, but if you want to take it on, I'm happy to help guide it. I'm going to close this PR since we can't merge it. Please let me know if there are more questions. Thanks |
issue: #430