Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump okhttp to v3 #483

Closed
wants to merge 1 commit into from
Closed

bump okhttp to v3 #483

wants to merge 1 commit into from

Conversation

tedli
Copy link

@tedli tedli commented Jan 16, 2019

issue: #430

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tedli
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mbohlool

If they are not already assigned, you can assign the PR to them by writing /assign @mbohlool in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 16, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 16, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 16, 2019
@tedli tedli force-pushed the okhttp3 branch 2 times, most recently from 3beff1e to fc5cdd5 Compare January 16, 2019 06:25
@tedli
Copy link
Author

tedli commented Jan 16, 2019

Is the current master branch without any touched able to pass those tests?

@tedli tedli changed the title bump okhttp to v3 WIP bump okhttp to v3 Jan 16, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2019
@tedli tedli changed the title WIP bump okhttp to v3 bump okhttp to v3 Jan 16, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2019
@tedli
Copy link
Author

tedli commented Jan 16, 2019

/assign @mbohlool

@brendandburns
Copy link
Contributor

Sadly this code is all auto-generated, we can't make manual changes in this code since we won't be able to regenerate it as the Kubernetes API changes.

The right path here is to regenerate the code to use something like feign instead of okhttp. It's a TODO, but if you want to take it on, I'm happy to help guide it.

I'm going to close this PR since we can't merge it. Please let me know if there are more questions.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants