Use synchronization classes instead of Thread.sleep in test cases

[tmrpavan]

Use synchronization classes instead of Thread.sleep in test cases

[Umbrella Issue] Many tests use Thread.sleep instead of synchronization primitives #1223

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tmrpavan
Once this PR has been reviewed and has the lgtm label, please assign brendandburns for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @tmrpavan!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[tmrpavan]

@brendandburns Can you review my PR

[brendandburns]

In this context, I'm not sure that sleep is a problem. We need to wait for a period of time, but we expect to be interrupted. Adding the lock.wait(10s) instead of sleep(10s) doesn't really change the expectation of an interrupt and I don't think it makes this test less flaky.

You could, in theory, make this test less flaky by blocking the thread until just before shutdown is called, and then waiting for a period of time to get interrupted by shutdown, but I don't think it's worth it.

[brendandburns]

(oh and many thanks for taking on these type of PRs, they're generally useful and hard to get contributions, so thanks! it's just that this one may not be quite as useful as others)

[tmrpavan]

@brendandburns Thanks for your comments. I will work on this

[tmrpavan]

/retest

[k8s-ci-robot]

@tmrpavan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tmrpavan]

Can anyone review this PR

[tmrpavan]

@brendandburns Can you please review this PR

[brendandburns]

I don't think that this change is really any different than the code that is already there. I think in this case, Thread.sleep(...) is actually the right thing to do in this test.

Let me know if I'm missing something.

Thanks!